Fix #4456: Pickle quote before compiling #4457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biboudis
reviewed
May 7, 2018
| @@ -22,7 +22,26 @@ import scala.reflect.ClassTag | |||
| object PickledQuotes { | |||
| import tpd._ | |||
|
|
|||
| /** Pickle the quote into strings */ | |||
| /** Pickle the tree of the a quoted.Expr */ | |||
| } | ||
| }.traverse(tree) | ||
| val pickled = pickleQuote(tree) | ||
| scala.runtime.quoted.Unpickler.unpickleExpr(pickled, Nil) |
There was a problem hiding this comment.
The Nil there makes me wonder what if this fix applies to non-inline functions.
There was a problem hiding this comment.
// ignore, I have just went through the second unit test and you do what I had in mind.
library/src/scala/quoted/Expr.scala
Outdated
| @@ -37,7 +37,8 @@ object Exprs { | |||
| } | |||
|
|
|||
| /** An Expr backed by a tree. Only the current compiler trees are allowed. */ | |||
There was a problem hiding this comment.
Clarify what we mean by "current compiler"?
|
LGTM. We need to update the documentation and describe the |
|
@biboudis check if this added documentation is clear enough |
|
The description of the exception is exceptional 👍 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.