Fix #3653: generic Java signature of FunctionXXL #4287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were encoding the generic Java signature of `FunctionN`s' with more than P parameters as `FunctionP<..params..>` (which doesn't exist), but in the bytecode, FunctionXXL is used instead. This commit fixes that, so that the generic signature matches `FunctionXXL`.
smarter
approved these changes
Apr 10, 2018
allanrenucci
approved these changes
Apr 10, 2018
| @@ -127,6 +127,9 @@ object GenericSignatures { | |||
| case ref @ TypeParamRef(_: PolyType, _) => | |||
| typeParamSig(ref.paramName.lastPart) | |||
|
|
|||
| case RefOrAppliedType(sym, _, _) if defn.isXXLFunctionClass(sym) => | |||
There was a problem hiding this comment.
Shouldn't you add it as a new case in the already existing if else chain starting line 186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were encoding the generic Java signature of
FunctionNs' with morethan P parameters as
FunctionP<..params..>(which doesn't exist), butin the bytecode, FunctionXXL is used instead.
This commit fixes that, so that the generic signature matches
FunctionXXL.Fixes #3653