Small performance enhancements #4267
Conversation
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
|
||
| /** perform context-dependant initialization */ | ||
| override def prepareForUnit(tree: Tree)(implicit ctx: Context) = { | ||
| primitiveGetClassMethods = Set[Symbol]() ++ defn.ScalaValueClasses().map(x => x.requiredMethod(nme.getClass_)) |
There was a problem hiding this comment.
So, the improvement is that before prepareForUnit returned all the symbols for getClass methods, by generating stubsymbols were needed, and now it doesn't?
There was a problem hiding this comment.
Yes. Mostly the cost was in creating the set.
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4267/ to see the changes. Benchmarks is based on merging with master (2f94916) |
| @@ -105,7 +105,7 @@ class InterceptedMethods extends MiniPhase { | |||
| List(qual, typer.resolveClassTag(tree.pos, qual.tpe.widen)))) | |||
| }*/ | |||
| */ | |||
| case t if primitiveGetClassMethods.contains(t) => | |||
| case t if t.name == nme.getClass_ && scalaValueClasses.contains(t.owner) => | |||
There was a problem hiding this comment.
I think you could just do defn.ScalaValueClasses.contains, no need for the intermediate variable.
|
test performance please |
|
performance test scheduled: 2 job(s) in queue, 1 running. |
|
There is some performance regression on some of the exhaustivity benchmarks. I will investigate before merging. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4267/ to see the changes. Benchmarks is based on merging with master (2f94916) |
|
Actually the performance regression was on master. |
No description provided.