Change owners only once for nested unpickled quotes #4238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4238/ to see the changes. Benchmarks is based on merging with master (7d01268) |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Yes, the current solution will break if there are nested definitions inside the quote. I will try accumulating the correct owner changes in a map and then apply them all at the end. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4238/ to see the changes. Benchmarks is based on merging with master (7d01268) |
nicolasstucki
force-pushed
the
quote-change-owner-once
branch
from
5660b89 to
f57ab64
Compare
|
A simpler and more performant fix is available in #4242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4235