Pretty print quotes #4213
Merged
Pretty print quotes #4213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,4 +51,16 @@ class DecompilerPrinter(_ctx: Context) extends RefinedPrinter(_ctx) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| override protected def toTextCore[T >: Untyped](tree: Tree[T]): Text = { | |||
There was a problem hiding this comment.
Why is not part of RefinedPrinter?
There was a problem hiding this comment.
Maybe it should
There was a problem hiding this comment.
No, we do not want this representation when debugging.
nicolasstucki
force-pushed
the
print-quotes-for-users
branch
from
cfb5ddd to
88ca3c1
Compare
allanrenucci
approved these changes
Apr 9, 2018
| override protected def toTextCore[T >: Untyped](tree: Tree[T]): Text = { | ||
| import untpd.{modsDeco => _, _} | ||
| tree match { | ||
| case TypeApply(fun, args) => |
There was a problem hiding this comment.
I think we should have a protected def for each type of tree and override the bits we are interested in.,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.