Skip to content

Optimize '(~x) to x to avoid pickling #4210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@biboudis
Copy link
Contributor

biboudis commented Mar 29, 2018

I wonder if the output of quote-nested-5.scala is right under this PR or not.
Under this PR the result of

val q = '{
  val a = '(4)
   ~('{
    '(~a)
  })
}

is a and not '(~a) which is correct, no?

@nicolasstucki
Copy link
Contributor Author

Yes, it should be a.

@nicolasstucki nicolasstucki force-pushed the optimize-simple-quote-splice branch from 2d40614 to 2caf690 Compare March 29, 2018 13:28
Copy link
Contributor

@biboudis biboudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki force-pushed the optimize-simple-quote-splice branch from 2caf690 to 5b54065 Compare March 29, 2018 14:24
@nicolasstucki
Copy link
Contributor Author

Rebased

@nicolasstucki nicolasstucki merged commit 4bc6c65 into scala:master Mar 29, 2018
@Blaisorblade Blaisorblade deleted the optimize-simple-quote-splice branch March 29, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants