use File.pathSeparator for classpath in genDocs

[robstoll]

• uses File.pathSeparator instead of hard-coded path separator :
  in genDocs => this way Windows user can run the command as well

[dottybot]

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

[smarter]

There are other uses of ":" in Build.scala, would you mind fixing them too?

[robstoll]

@smarter Might be that the following should be fixed as well but could be done in a separate pull request if needed:
https://github.com/lampepfl/dotty/blob/e9b5a976a6931b13f2fd330a9e724dea764ae7bb/compiler/src/dotty/tools/dotc/fromtasty/Debug.scala#L68

https://github.com/lampepfl/dotty/blob/e9b5a976a6931b13f2fd330a9e724dea764ae7bb/doc-tool/test/GenDocs.scala#L26

[robstoll]

An improvement would be to reduce code duplication between genDocs and dottydoc, lines 366-370 and 388-391 are the same. This is my first encounter with sbt and I don't know how to move code into an own function without encountering the error that I cannot access value outside of a task macro definition.
Would be great if someone could do that (surely an easy task) so that I know how to do it next time :)

[allanrenucci]

Would be great if someone could do that (surely an easy task) so that I know how to do it next time :)

Probably something like this:

diff --git a/project/Build.scala b/project/Build.scala
index 4d7f1ad1d..df0b5e13d 100644
--- a/project/Build.scala
+++ b/project/Build.scala
@@ -345,6 +345,13 @@ object Build {
       javacOptions in (Compile, doc) --= Seq("-Xlint:unchecked", "-Xlint:deprecation")
     )
 
+  private lazy val dottydocClasspath = Def.task {
+    val dottyLib = (packageAll in `dotty-compiler`).value("dotty-library")
+    val dottyInterfaces = (packageAll in `dotty-compiler`).value("dotty-interfaces")
+    val otherDeps = (dependencyClasspath in Compile).value.map(_.data).mkString(File.pathSeparator)
+    dottyLib + File.pathSeparator + dottyInterfaces + File.pathSeparator + otherDeps
+  }
+
   // Settings shared between dotty-doc and dotty-doc-bootstrapped
   lazy val dottyDocSettings = Seq(
     baseDirectory in (Compile, run) := baseDirectory.value / "..",
@@ -364,9 +371,6 @@ object Build {
       val majorVersion = baseVersion.take(baseVersion.lastIndexOf('.'))
       IO.write(file("./docs/_site/versions/latest-nightly-base"), majorVersion)
 
-      val dottyLib = (packageAll in `dotty-compiler`).value("dotty-library")
-      val dottyInterfaces = (packageAll in `dotty-compiler`).value("dotty-interfaces")
-      val otherDeps = (dependencyClasspath in Compile).value.map(_.data).mkString(":")
       val sources =
         (unmanagedSources in (Compile, compile)).value ++
           (unmanagedSources in (`dotty-compiler`, Compile)).value
@@ -375,7 +379,7 @@ object Build {
         "-project", "Dotty",
         "-project-version", dottyVersion,
         "-project-url", dottyGithubUrl,
-        "-classpath", s"$dottyLib:$dottyInterfaces:$otherDeps"
+        "-classpath", dottydocClasspath.value
       )
       (runMain in Compile).toTask(
         s""" dotty.tools.dottydoc.Main ${args.mkString(" ")} ${sources.mkString(" ")}"""
@@ -384,10 +388,7 @@ object Build {
 
     dottydoc := Def.inputTaskDyn {
       val args: Seq[String] = spaceDelimited("<arg>").parsed
-      val dottyLib = (packageAll in `dotty-compiler`).value("dotty-library")
-      val dottyInterfaces = (packageAll in `dotty-compiler`).value("dotty-interfaces")
-      val otherDeps = (dependencyClasspath in Compile).value.map(_.data).mkString(":")
-      val cp: Seq[String] = Seq("-classpath", s"$dottyLib:$dottyInterfaces:$otherDeps")
+      val cp: Seq[String] = Seq("-classpath",dottydocClasspath.value)
         (runMain in Compile).toTask(s""" dotty.tools.dottydoc.Main ${cp.mkString(" ")} """ + args.mkString(" "))
     }.evaluated,

[robstoll]

I have rebased the branch and made the improvement accordingly

[allanrenucci]

Thanks @robstoll! LGTM provided the tests pass