Avoid "missing parameter type" error when checking isMatchedBy
#4165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking whether a FunProto is applicable to an argument, we should avoid falling into "missing parameter type" errors. Better to assume a WildcardType for the argument instead. This follows the general principle to err on the side of generosity when checking `isMatchedBy`.
smarter
approved these changes
Mar 23, 2018
| myTypedArg = myTypedArg.updated(arg, targ) | ||
| evalState = evalState.updated(arg, (ctx.typerState, ctx.typerState.constraint)) | ||
| if (!force && untpd.functionWithUnknownParamType(arg).isDefined) | ||
| // If force = true, assume ? rather than reporting an error. |
|
I got: Running Vulpix meta test
This after changing a simple doc comment. It looks like the Vulpix meta test is flakey. We need to fix it or disable it. (This is not the first time it happened to me). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking whether a FunProto is applicable to an argument, we should avoid
falling into "missing parameter type" errors. Better to assume a WildcardType
for the argument instead. This follows the general principle to err on the side
of generosity when checking
isMatchedBy.