Correct the position of root symbols unpickled from TASTY #4112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix/tasty-root-pos
branch
from
66897b0 to
6552434
Compare
This require mutating Symbol#coord since the position is not known when the symbol is created. This is needed to get `-Ythrough-tasty tests/pos/t247.scala` to compile because the position of bridge definitions is sometimes set using the position of the enclosing class.
smarter
force-pushed
the
fix/tasty-root-pos
branch
from
6552434 to
d76e857
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This require mutating Symbol#coord since the position is not known when
the symbol is created. This is needed to get
-Ythrough-tasty tests/pos/t247.scalato compile because the position of bridgedefinitions is sometimes set using the position of the enclosing class.