Fix #3976: Fix Eq method for enums with higher-kinded parameters #3982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Feb 11, 2018
| def appliedRef(tycon: Tree, tparams: List[TypeDef] = constrTparams) = | ||
| appliedTypeTree(tycon, tparams map refOfDef) | ||
| def appliedRef(tycon: Tree, tparams: List[TypeDef] = constrTparams, widenHK: Boolean = false) = { | ||
| var targs = for (tparam <- tparams) yield { |
tests/pos/i3976.scala
Outdated
| @@ -0,0 +1 @@ | |||
| enum class Hoge[F[_]] | |||
There was a problem hiding this comment.
I would add a test with an M[_[_]] param, and perhaps some code that exercises the generated Eq implicits too to make sure it works as expected.
- More extensive use cases - Defining enum cases with wrong kinds in extension clauses caused a crash in argDenot, which is fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.