PostTyper#normalizeTypeArgs: fast path to avoid allocations #3948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to -Yprofile-enabled, this reduces the amount of memory allocated in PostTyper when compiling re2s from 39 MB to 26 MB
smarter
force-pushed
the
opt/posttyper-fastpath
branch
from
35a4344 to
5ccec02
Compare
|
@nicolasstucki I had to disable tests/run-with-compiler/quote-run-constants-extract.scala because it times out. |
|
I believe some of the quote tests are too aggressive, causing stackoverflows or timeouts in normal situations. We should make them less resource hungry. |
odersky
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to -Yprofile-enabled, this reduces the amount of memory
allocated in PostTyper when compiling re2s from 39 MB to 26 MB