Skip to content

Allow interpretation of inline methods in value classes and varargs #3913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2018
Merged

Allow interpretation of inline methods in value classes and varargs #3913

merged 2 commits into from
Jan 25, 2018

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

liufengyun
liufengyun approved these changes Jan 25, 2018
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'll create an issue for the handling of value classes, which causes exception if new ValueClass(v) is also interpreted.

@nicolasstucki
Copy link
Contributor Author

I will merge it like this. It will serve as a regression test for the definition of macro string interpolators. We will create an issue for the case where we inline an explicit value class.

@nicolasstucki nicolasstucki merged commit 78bd3dd into scala:master Jan 25, 2018
@liufengyun liufengyun mentioned this pull request Jan 25, 2018
Closed
@allanrenucci allanrenucci deleted the upstreams-interpreter-enhancements branch January 25, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun