Fix #3721: Roll back SubstMap functionality into general TreeTypeMap #3868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
|
performance test scheduled: 3 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3868/ to see the changes. Benchmarks is based on merging with master (79281da) |
|
No change in performance, and we have identified another likely culprit. So it comes down to whether the simplification is worth it. |
|
I think the simplification is probably large enough to justify the change. |
Adding SubstMap is a bit clunky and might have been a performance regression. Trying to do without it by rolling back its hebavior to regular TreeTypeMaps. Downsides: - loss of modularity (TreeTypeMaps have to know about holes) - possible loss of error checking (normal TreeTypeMaps no longer crash when seeing a hole)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SubstMap is a bit clunky and might have been a performance regression.
Trying to do without it by rolling back its hehavior to regular TreeTypeMaps.
Downsides: