Enable optimisations in Expr.run
#3830
Conversation
|
Optimizations have a significant impact on compilation time, and not much effect on running time, why should they be enabled by default? |
|
It should probably be an option of the |
nicolasstucki
force-pushed
the
enable-optimise-in-quotes
branch
from
c9a159c to
c653b1a
Compare
| @@ -13,10 +13,9 @@ import java.nio.charset.StandardCharsets | |||
|
|
|||
| class QuoteDriver extends Driver { | |||
|
|
|||
| def run[T](expr: Expr[T]): T = { | |||
| def run[T](expr: Expr[T], optimise: Boolean): T = { | |||
There was a problem hiding this comment.
That will work for now, but in the future if you want to be able to pass more options, it might make more sense to pass a Settings object.
There was a problem hiding this comment.
I will add it now to avoid future changes on the API.
nicolasstucki
force-pushed
the
enable-optimise-in-quotes
branch
from
168e90e to
6be81fa
Compare
|
@smarter this PR needs another review, I added |
| @@ -31,6 +31,7 @@ object Runners { | |||
| } | |||
|
|
|||
| case class RunSettings( | |||
| optimise: Boolean = false | |||
| optimise: Boolean = false, | |||
| outDir: Option[String] = None | |||
There was a problem hiding this comment.
outputDir, also document the meaning of Some/None here.
There was a problem hiding this comment.
You can do java -Djdk.internal.lambda.dumpProxyClasses=out to be able to debug the classes generated for lambda calls at runtime. Maybe we should have a -Ddotty.meta.dumpClasses or something for similar purpose.
nicolasstucki
force-pushed
the
enable-optimise-in-quotes
branch
from
3dca938 to
873058b
Compare
No description provided.