Fix Tasty unpickling of a TEMPLATE with a SHARED parent #3824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: would be good if someone double-checked that there aren't other places where we use |
|
The test failure is due to a missing position for an unpickled tree, I'll investigate. |
smarter
force-pushed
the
fix-tasty-shared-parent
branch
2 times, most recently
from
17dc5b1 to
ec723f4
Compare
In general, this makes things easier to debug at virtually no cost. It also makes it much easier to properly set positions on unpickled TypeTrees: in TreeUnpickler#readTpt we can know make sure that the position of the TypeTree is unpickled from the address found after following all shared terms but before following any shared type. Note that the major version bump could have been avoided by adding some compatibility code, but that doesn't seem worthwhile until Tasty is used in the wild.
smarter
force-pushed
the
fix-tasty-shared-parent
branch
from
ec723f4 to
4c5b6ef
Compare
|
Ready for review. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.