Fix #2495: Improve error message #3804
Conversation
|
I think we should would avoid using REPL scripted tests to test error messages. It is very fragile. We'll have to fix the tests every time we change pretty printing, change the wording of the message... |
|
The idea of this test is to show that the pretty printed version looks as expected. This is the best that can be done for this issue. The alternative is not testing it. |
|
Yeah, I don't think this deserves a test. My opinion for error messages is to test that the right error message is emitted and that it contains the right semantic information (if any). But not test how it is pretty printed. I'll leave the last word to @smarter 😄 |
allanrenucci
requested review from
smarter
and removed request for
allanrenucci
|
I will remove it, it will be partially tested by the old scripted test. |
nicolasstucki
requested review from
liufengyun
and removed request for
smarter
| |The argument types of an anonymous function must be fully known. (SLS 8.5)""" | ||
| i"""missing parameter type | ||
| | | ||
| |The argument types of an anonymous function must be fully known. (SLS 8.5) |
There was a problem hiding this comment.
It's better to have this general reference at the end, and put more specific information before.
There was a problem hiding this comment.
This is part of the missing parameter type explaination.
There was a problem hiding this comment.
It also follows the old format in scalac that users said was clearer.
No description provided.