Fix #2789 #3753
Merged
Fix #2789 #3753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Jan 4, 2018
| @@ -115,4 +115,9 @@ class ReplCompilerTests extends ReplTest { | |||
| // storedOutput().startsWith("scala.MatchError: null") | |||
| // } | |||
| } | |||
|
|
|||
| @Test def i2789: Unit = fromInitialState { implicit state => | |||
| compile("(x: Int) => println(x)") | |||
There was a problem hiding this comment.
Why not put this in a repl script test?
There was a problem hiding this comment.
Because it prints something like this:
val res0: Int => Unit = Lambda$1423/1112073835@3e6534e7which is not deterministic
smarter
reviewed
Jan 4, 2018
| @@ -93,27 +93,27 @@ class ReplCompilerTests extends ReplTest { | |||
| ) | |||
| } | |||
|
|
|||
| @Test def i3305: Unit = { | |||
| // FIXME: Tests are not run in isolation, the classloader is corrupted after the first exception | |||
|
Do you know what PR fixed the underlying problem with anonymous function parsing? |
|
allanrenucci
force-pushed
the
fix-#2789
branch
from
1356384 to
96791ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #1424 too?