Skip to content

Fix #3557: Add regression test #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2018
Merged

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jan 1, 2018

The test now compiles with errors, which is what we would expect.

The test now compiles with errors, which is what we would expect.
@odersky odersky requested a review from allanrenucci January 1, 2018 17:00
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a crash anymore however the error emitted is very confusing:

class C2 {
  def f(values: String*) = ()
  class C3 {
    @f.varargs
    def g = ???
  }
}
-- [E081] Syntax Error: tests/allan/Test.scala:21:5 ----------------------------
21 |    @f.varargs
   |     ^
   | missing parameter type for parameter values, expected = ?{ varargs: ? }

I would add the regression test but keep the issue open

@smarter
Copy link
Member

smarter commented Jan 1, 2018

I would add the regression test but keep the issue open

I think we should open a separate issue for that, the crash is fixed and that's what the original issue was about.

@odersky odersky merged commit 12ff291 into scala:master Jan 2, 2018
@allanrenucci allanrenucci deleted the fix-#3557 branch January 2, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants