Skip to content

Fixes and extensions to symmetric meta programming docs #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 13, 2018

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 23, 2017

No description provided.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Added" instead of "Add")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@odersky odersky force-pushed the simple-smp branch 2 times, most recently from 607788c to 9258079 Compare December 23, 2017 13:40
@@ -0,0 +1,229 @@
# Simple Symmetric Metaprogramming
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should have a header like I added in #3696

Copy link
Contributor

@Blaisorblade Blaisorblade May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems still a problem, and why http://dotty.epfl.ch/docs/simple-smp.html is still a dead link. Fixing. EDIT: http://dotty.epfl.ch/docs/reference/simple-smp.html is fine, the problem's in the link it seems, I'll look into it.

@odersky odersky force-pushed the simple-smp branch 2 times, most recently from 80c54f1 to 043b5fd Compare December 23, 2017 17:52

This note presents a simplified variant of symmetric meta-programming
and sketches its soundness proof. The variant treats only dialogues
between two stages. A program can have quotes which can contain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double space

and sketches its soundness proof. The variant treats only dialogues
between two stages. A program can have quotes which can contain
splices (which can contain quotes, which can contain splices, and so
on). Or the program could start with a splice with embedded
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double space


23.12.2017

This note presents a simplified variant of symmetric meta-programming
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a link to the symmetric meta-programming doc here.

@@ -15,4 +15,5 @@ abstract class Liftable[T] {
object Liftable {
implicit def IntIsLiftable: Liftable[Int] = ???
implicit def BooleanIsLiftable: Liftable[Boolean] = ???
implicit def StringIsLiftable: Liftable[String] = ???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already added along with all other constants

with a sketch of its meta theory.
Make sure `assertImpl` prints the tested expression rather than its result.
Add links between symmetric-meta-programming and simple-smp.
@odersky odersky merged commit 08e6735 into scala:master Jan 13, 2018
@allanrenucci allanrenucci deleted the simple-smp branch January 14, 2018 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants