Split Compiler.phases into smaller logical groups #3671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Dec 18, 2017
| new LambdaLift, // Lifts out nested functions to class scope, storing free variables in environments | ||
| frontendPhases ::: picklerPhases ::: transformPhases ::: backendPhases | ||
|
|
||
| /** Phases dealing with the the frontend up to trees ready for TASTY pickling */ |
| List(new LinkAll) :: // Reload compilation units from TASTY for library code (if needed) | ||
| Nil | ||
|
|
||
| /** Phases dealing transforming from pickled trees to backend trees */ |
There was a problem hiding this comment.
"dealing transforming" is not correct grammar
| protected def transformPhases: List[List[Phase]] = | ||
| List(new FirstTransform, // Some transformations to put trees into a canonical form | ||
| new CheckReentrant, // Internal use only: Check that compiled program has no data races involving global vars | ||
| new ElimJavaPackages) :: // Eliminate syntactic references to Java packages |
There was a problem hiding this comment.
Why use :: instead of List(List(...), ...) ?
There was a problem hiding this comment.
I personally prefer List(List(...), ...) 😄
There was a problem hiding this comment.
I thought it would make a better distinction between micro and macro phases and it is a little bit more efficient.
nicolasstucki
force-pushed
the
split-compiler-phases
branch
2 times, most recently
from
10aa8cb to
0fe84d4
Compare
odersky
approved these changes
Dec 21, 2017
nicolasstucki
force-pushed
the
split-compiler-phases
branch
from
0fe84d4 to
d732ae4
Compare
|
Rebased after addition of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to simplify overriding of
phasesin classes that extendCompiler. It also splits the macro phases into groups that share a same logical purpose.