Fix #3581: Reorganise neg tests #3612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
commented
Nov 30, 2017
| } | ||
| } | ||
| } | ||
| package p4 { | ||
|
|
||
| trait A { self: Any { def p: Any } => | ||
| def f(b: => Unit): Unit = {} | ||
| f { p } // error: cannot access member 'p' from structural type | ||
| f { p } // OK |
There was a problem hiding this comment.
Is it intended?
|
I had to move |
allanrenucci
force-pushed
the
neg-tests
branch
2 times, most recently
from
ae9d2a5 to
6959f06
Compare
allanrenucci
force-pushed
the
neg-tests
branch
from
6959f06 to
55c62c3
Compare
smarter
approved these changes
Dec 1, 2017
| @@ -149,7 +149,8 @@ abstract class CompilerTest { | |||
|
|
|||
| private def expectedErrors(filePath: String): List[ErrorsInFile] = expectedErrors(List(filePath)) | |||
|
|
|||
| private def isNegTest(testPath: String) = testPath.contains("/neg/") | |||
| private def isNegTest(testPath: String) = | |||
| testPath.contains("/neg/") || testPath.contains("/neg-custom-args/") || testPath.contains("/neg-tailcall/") | |||
There was a problem hiding this comment.
I believe the full path is given here. Something like ../tests/neg/Foo.scala. I wouldn't bother to do something smarter since this is for the legacy tests
Could you open an issue for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.