Fix #3467: Don't pre-check kinds in TypeAssigner #3567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the existing tests we only need to pre-check kinds in Typer in order to avoid self-applications that can lead to crashes. By avoiding them in TypeAssigner we also avoid the error exhibited by i3467 in the strawman collections. This change required some changes in the tests because errors now get reported at different times.
smarter
approved these changes
Nov 27, 2017
| @@ -0,0 +1,16 @@ | |||
| object Test { | |||
There was a problem hiding this comment.
This file and kinds2.scala are almost identitical, the other one could be removed.
There was a problem hiding this comment.
kinds2.scala tests another error. So I think we should keep it
There was a problem hiding this comment.
Any reason to not test f[C] in this file?
There was a problem hiding this comment.
I believe because the error is not reported with this file:
This change required some changes in the tests because errors now get reported
at different times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing tests we only need to pre-check kinds in Typer in order
to avoid self-applications that can lead to crashes. By avoiding them in
TypeAssigner we also avoid the error exhibited by i3467 in the strawman
collections.
This change required some changes in the tests because errors now get reported
at different times.