Skip to content

Improve doc readability #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2017
Merged

Improve doc readability #3554

merged 1 commit into from
Nov 27, 2017

Conversation

k0ala
Copy link
Contributor

@k0ala k0ala commented Nov 24, 2017

This is attempting to address some readability issues, by modifying the CSS files in the doc-tool resources in just 2 places:

  • increase sidebar font size
  • make toolbar darker (to increase contrast with the light title text)

dottybot
dottybot reviewed Nov 24, 2017
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@allanrenucci
Copy link
Contributor

Hi @k0ala! Thank you for the contribution.

Could you post screenshots of the diff you propose?

@k0ala
Copy link
Contributor Author

k0ala commented Nov 25, 2017

Certainly! Here is before and after:

before

after

@allanrenucci allanrenucci merged commit 2070b25 into scala:master Nov 27, 2017
@allanrenucci
Copy link
Contributor

Awesome. Thanks @k0ala!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k0ala @allanrenucci @dottybot