Skip to content

-Xverify-signatures: emit errors, not warnings #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2017
Merged

-Xverify-signatures: emit errors, not warnings #3534

merged 1 commit into from
Nov 23, 2017

Conversation

smarter
Copy link
Member

@smarter smarter commented Nov 22, 2017

Otherwise the tests will still succeed.

@smarter
-Xverify-signatures: emit errors, not warnings
df42072 
Otherwise the tests will still succeed.
@smarter smarter requested a review from Duhemm November 22, 2017 23:55
Duhemm
Duhemm approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@Duhemm Duhemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe that we should add a message to say that generic signatures can be disabled with -Yno-generic-signatures, in case people get blocked by a bug.

@smarter
Copy link
Member Author

smarter commented Nov 23, 2017

-Xverify-signatures is not enabled by default, so in what situation would people be blocked by this?

@smarter smarter merged commit 257f088 into scala:master Nov 23, 2017
@Duhemm
Copy link
Contributor

Duhemm commented Nov 23, 2017

🤦‍♂️ You're absolutely right

@allanrenucci allanrenucci deleted the fix-verify-signature branch December 14, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duhemm Duhemm Duhemm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smarter @Duhemm