#1589: add dedicated error message for missing companion for static members #3530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
suggested changes
Nov 23, 2017
| checkMessagesAfter("checkStatic") { | ||
| """ | ||
| |object Foo { | ||
| | @annotation.static def bar(): Unit = bar() |
| assertEquals(member.show, "method bar") | ||
| } | ||
|
|
||
| @Test def notMissingCompanionForStatic = |
There was a problem hiding this comment.
You can remote this test. Here we only test the content of error messages.
We already have tests for correct and incorrect programs: tests/run/statics.scala, tests/neg/static-no-companion.scala
| val msg = hl"${member.owner} does not have a companion class" | ||
| val kind = "Syntax" | ||
| val explanation = | ||
| hl"object that contains @static members must have a companion class." |
There was a problem hiding this comment.
hl"Object that contain ${"@static"} members must have a companion class."There was a problem hiding this comment.
I propose a slight change:
hl"An object that contains ${"@static"} members must have a companion class."
esarbe
force-pushed
the
staticMissesCompanion
branch
from
8746fdb to
f3ffd52
Compare
|
Can you rebase? |
esarbe
force-pushed
the
staticMissesCompanion
branch
from
f3ffd52 to
46e1aad
Compare
|
Of course. |
allanrenucci
approved these changes
Nov 27, 2017
|
Thanks @esarbe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.