Fix position of desugared tree wrapped in parentheses #3527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
approved these changes
Nov 22, 2017
| case _ => | ||
| } | ||
|
|
||
| val desugared = tree match { |
There was a problem hiding this comment.
You can remove the Parens case in this pattern match
compiler/test-resources/repl/errmsgs
Outdated
| @@ -64,3 +64,7 @@ scala> { def f: Int = g; val x: Int = 1; def g: Int = 5; } | |||
| 1 | { def f: Int = g; val x: Int = 1; def g: Int = 5; } | |||
| | ^ | |||
| | `g` is a forward reference extending over the definition of `x` | |||
| scala> while ((( foo ))) {} | |||
| 1 |while ((( foo ))) {} | |||
There was a problem hiding this comment.
You need to shift the error message by one space after the |. This is a weird issue. I haven't figure it out yet
smarter
force-pushed
the
fix-parens-desugar
branch
from
e22f511 to
a1bd44a
Compare
allanrenucci
force-pushed
the
fix-parens-desugar
branch
from
a1bd44a to
ff4fa78
Compare
Before this commit, the added testcase produced the following result:
scala> while ((( foo ))) {}
1 |while ((( foo ))) {}
| ^^^^^^^^^^^
| not found: foo
allanrenucci
force-pushed
the
fix-parens-desugar
branch
from
ff4fa78 to
7bce28e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the added testcase produced the following result: