Fix #3480: Fix expanded name #3491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanded name behaved different from what would be expected by the fullNameSeparated conventions. This led to local dummies creeping in the expanded names for local definitions in templates.
smarter
reviewed
Nov 16, 2017
| Foo$$init$$$bar$1 | ||
| Foo$$init$$$bar$2 | ||
| Bar$$init$$$bar$1 | ||
| Foo$$_$bar$1 |
There was a problem hiding this comment.
Why was this changed? Isn't this going to make debugging more difficult?
There was a problem hiding this comment.
It makes things more regular. Fully qualified names in general represent terms in the owner chain with "_$". The problem was that we treated the last separator of an expanded name as different from the others. This looks wrong. It's a different question what fully qualified names should do to represent term owners in the chain. AFAIK scalac skips them completely.
smarter
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded name behaved different from what would be expected
by the fullNameSeparated conventions. This led to local
dummies creeping in the expanded names for local definitions
in templates.