-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #3333: adapt child instantiation #3475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
10: Pattern Match Exhaustivity: _: IntNumber, NotNaN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
sealed trait IntegralNumber | ||
|
||
object IntegralNumber { | ||
object NaN extends IntegralNumber | ||
object NotNaN extends IntegralNumber | ||
|
||
sealed abstract class FiniteNumberImpl[N](val value: N) extends IntegralNumber | ||
sealed class IntNumber(value: Int) extends FiniteNumberImpl[Int](value) | ||
|
||
def test(o: IntegralNumber) = o match { | ||
case NaN => -1 | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
11: Pattern Match Exhaustivity: Decimal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
trait AxisCompanion { | ||
sealed trait Format | ||
object Format { | ||
case object Decimal extends Format | ||
case object Integer extends Format | ||
} | ||
} | ||
object Axis extends AxisCompanion | ||
class Axis { | ||
import Axis._ | ||
def test( f: Format ) = f match { | ||
case Format.Integer => "Int" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
object O { | ||
sealed trait Trait[+A] { type T } | ||
case class CaseClass[+A](a: A) extends Trait[A] { type T = Nothing } | ||
|
||
def id[TT, A](v: Trait[A] { type T = TT }): Trait[A] { type T = TT } = | ||
v match { | ||
case CaseClass(a) => CaseClass(a) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity: what was the original issue here? Was
tp
present somewhere intp.underlying
? If yes, then wouldn't simply first creating the TVar, memoising it in a map keyed undertp
and mapping overtp.underlying
be enough? I'm asking, as basing on this code I wrote this and I'm not sure if it is correct.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot exactly what's the problem, but it's related to
ClassInfo#selfType
.tp.underlying
is supposed to be decreasing (I assume), so I think the case you mention will not occur. For the task you want to deal with, the memoization in your code is correct.