Skip to content

cleanup error messages tests, remove unused values #3380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2017
Merged

cleanup error messages tests, remove unused values #3380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val OverridesNothing(member) :: Nil = messages
Expand All @@ -78,7 +77,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val OverridesNothingButNameExists(member, sameName) :: Nil = messages
Expand All @@ -103,7 +101,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val ForwardReferenceExtendsOverDefinition(value, definition) :: Nil = messages
Expand All @@ -121,7 +118,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val ExpectedTokenButFound(expected, found) :: Nil = messages
Expand Down Expand Up @@ -153,7 +149,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val MixedLeftAndRightAssociativeOps(op1, op2, op2LeftAssoc) :: Nil = messages
Expand All @@ -173,7 +168,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val CantInstantiateAbstractClassOrTrait(cls, isTrait) :: Nil = messages
Expand All @@ -192,7 +186,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val CantInstantiateAbstractClassOrTrait(cls, isTrait) :: Nil = messages
Expand All @@ -211,7 +204,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val OverloadedOrRecursiveMethodNeedsResultType(treeName) :: Nil = messages
Expand Down Expand Up @@ -243,7 +235,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val OverloadedOrRecursiveMethodNeedsResultType(treeName) :: Nil = messages
Expand All @@ -260,7 +251,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val RecursiveValueNeedsResultType(tree) :: Nil = messages
Expand All @@ -278,7 +268,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val CyclicReferenceInvolving(denot) :: Nil = messages
Expand All @@ -299,7 +288,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val CyclicReferenceInvolvingImplicit(tree) :: Nil = messages
Expand All @@ -323,7 +311,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val SuperQualMustBeParent(qual, cls) :: Nil = messages
Expand Down Expand Up @@ -351,7 +338,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

import typer.Typer.BindingPrec._

Expand All @@ -373,7 +359,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val MethodDoesNotTakeParameters(tree, methodPart) :: Nil = messages
Expand All @@ -393,7 +378,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val MethodDoesNotTakeParameters(tree, methodPart) :: Nil = messages
Expand All @@ -418,7 +402,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val AmbiguousOverload(tree, List(alt1, alt2), pt: WildcardType) :: Nil = messages
Expand Down Expand Up @@ -452,7 +435,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val TypeDoesNotTakeParameters(tpe, params) :: Nil = messages
Expand All @@ -468,7 +450,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val ParameterizedTypeLacksArguments(symbol) :: Nil = messages
Expand Down Expand Up @@ -829,7 +810,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val AnonymousFunctionMissingParamType(param, args, _, pt) :: Nil = messages
Expand Down Expand Up @@ -886,7 +866,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val err :: Nil = messages
Expand All @@ -903,7 +882,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(2, messages)
messages.foreach(assertEquals(_, ImplicitFunctionTypeNeedsNonEmptyParameterList()))
Expand All @@ -918,7 +896,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val err :: Nil = messages
Expand All @@ -934,7 +911,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val err :: Nil = messages
Expand All @@ -948,7 +924,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val err :: Nil = messages
Expand Down