Skip to content

Make tests for locality of unique indices not depend on order #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2017

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki
Copy link
Contributor Author

The check files of these tests have changed a few times due to changes in the miniphases order and tree structure. This PR makes these test independent of the order, which was never intended to be tested in the first place.

Currently #3350 and one of my local branches are affected by this.

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to remove this stumbling block.

@nicolasstucki nicolasstucki merged commit 4dc4bd6 into scala:master Oct 20, 2017
@allanrenucci allanrenucci deleted the imporve-tests branch October 24, 2017 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants