Make MissingCoreLibTests a simple unit test #3356
Merged
+10
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
suggested changes
Oct 20, 2017
| compileFile("../tests/neg/nolib/Foo.scala", TestFlags(classPath, options)).checkExpectedErrors() | ||
| val source = "../tests/neg/nolib/Foo.scala" | ||
| val options = Array("-classpath", classPath, source) | ||
| val reporter = Main.process(options) |
There was a problem hiding this comment.
You are not handling the case where the compiler crashes, vulpix did that. A try/catch and assertTrue(false, ex.stackTrace) a good enough replacement.
There was a problem hiding this comment.
My understanding is that if something in the test crashes, the test fails
allanrenucci
force-pushed
the
missing-core-lib
branch
from
27a4ad9 to
cad618e
Compare
nicolasstucki
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see pros for it being a vulpix test