Add new style error message for @tailrec #3312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Oct 12, 2017
esarbe
force-pushed
the
messages-tailrec2
branch
from
dc1c089 to
bc6ac51
Compare
allanrenucci
suggested changes
Oct 23, 2017
| @@ -1786,4 +1787,15 @@ object messages { | |||
| |If you want to create an ${"enum"} case, make sure the corresponding ${"enum class"} exists | |||
| |and has the ${"enum"} keyword.""" | |||
| } | |||
|
|
|||
|
|
|||
| case class TailrecNotApplicableNeitherPrivateNorFinal(owner: Symbol)(implicit ctx: Context) | |||
There was a problem hiding this comment.
I would simply call it TailrecNotApplicable and TailrecNotApplicableID
| @@ -1786,4 +1787,15 @@ object messages { | |||
| |If you want to create an ${"enum"} case, make sure the corresponding ${"enum class"} exists | |||
| |and has the ${"enum"} keyword.""" | |||
| } | |||
|
|
|||
|
|
|||
| case class TailrecNotApplicableNeitherPrivateNorFinal(owner: Symbol)(implicit ctx: Context) | |||
There was a problem hiding this comment.
method is a better name than owner
| | @scala.annotation.tailrec | ||
| | def foo: Unit = foo | ||
| | | ||
| |} |
There was a problem hiding this comment.
This file is already big enough. Let's remove unnecessary blank lines:
"""class Foo {
| @scala.annotation.tailrec
| def foo: Unit = foo
|}
""".stripMargin| case class TailrecNotApplicableNeitherPrivateNorFinal(owner: Symbol)(implicit ctx: Context) | ||
| extends Message(TailrecNotApplicableNeitherPrivateNorFinalID) { | ||
| val kind = "Syntax" | ||
| val msg = hl"TailRec optimisation not applicable, ${owner} is neither `private` nor `final` so can be overridden" |
There was a problem hiding this comment.
val msg = hl"TailRec optimisation not applicable, $owner is neither ${"private"} nor ${"final"}."| val explanation = | ||
| hl""" | ||
| |The `@tailrec` annotation can only be used on methods that are either `private` or `final`. | ||
| """ |
There was a problem hiding this comment.
val explanation =
hl"A method annotated ${"@tailrec"} must be declared ${"private"} or ${"final"} so it can't be overridden."
esarbe
force-pushed
the
messages-tailrec2
branch
from
8f434b9 to
fef6455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1589