sbt.ExtractAPI: Support TypeArgRef #3280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
sbt-extract-typeargref
branch
from
eaa4594 to
ecdb624
Compare
TypeArgRef can leak to method signatures, therefore it needs to be handled in ExtractAPI for incremental compilation to work correctly.
smarter
force-pushed
the
sbt-extract-typeargref
branch
from
ecdb624 to
0b565cb
Compare
odersky
approved these changes
Oct 7, 2017
| @@ -343,6 +344,12 @@ private class ExtractAPICollector(implicit val ctx: Context) extends ThunkHolder | |||
| } | |||
| } | |||
|
|
|||
| // Hack to represent dotty types which don't have an equivalent in xsbti | |||
| def combineApiTypes(apiTps: api.Type*): api.Type = { | |||
There was a problem hiding this comment.
I have no idea what this is supposed to achieve.
There was a problem hiding this comment.
Basically fitting a square peg in a round hole: sbt has its own representation of types which doesn't include anything like TypeArgRef, but we can still get incremental compilation to work correctly if we can find a bijection between dotty's types and sbt's types, since the only thing that matter is that the hash of the sbt type changes when the dotty type changes. Don't worry too much about it :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeArgRef can leak to method signatures, therefore it needs to be
handled in ExtractAPI for incremental compilation to work correctly.
@odersky : See sbt-dotty/sbt-test/source-dependencies/typeargref/A.scala for an example where a TypeArgRef leaks to the signature. This example seems dubious to me since there's no reason we couldn't use the underlying type here, so let me know if you can come up with a more reasonable example.