Optimizations: Make code inlining friendlier #3265
Conversation
|
test performance please |
|
performance test scheduled: 11 job(s) in queue, 1 running. |
odersky
force-pushed
the
try-optimize-8
branch
from
cf70732 to
9a7ea3c
Compare
|
test performance please |
|
performance test scheduled: 6 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3265/ to see the changes. Benchmarks is based on merging with master (af528a1) |
odersky
changed the title
|
test performance please |
|
performance test scheduled: 21 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3265/ to see the changes. Benchmarks is based on merging with master (2ecd3d2) |
Making completion printing a config option keeps the size of key method `SymDenotations#completeFrom` small.
This is useful for keeping code small.
- Enable only if global config option is true (this avoids clutter in traced methods). - Move out of context into separate object `reporting.trace`. - Avoid default arguments, since these are loaded before inlining. The net effect of these methods is no parts of tracing calls remain in generated code if config.tracingEnabled is false.
In particular, this test the changes to constant folding done two commits ago.
smarter
force-pushed
the
try-optimize-8
branch
from
f3e0a15 to
745fa3d
Compare
| case y :: Nil if y.tpe.widen.isRef(defn.BooleanClass) => | ||
| op match { | ||
| case nme.ZAND => if (c) y else x | ||
| case nme.ZOR => if (c) x else y |
There was a problem hiding this comment.
Probably doesn't matter in this case, but I prefer to check the symbol's name (or identity), rather than the selected name, so as to avoid mis-classification in the presence of renaming imports.
I noted that despite inlining and the printer scheme key operations had a lot of junk in them. This PR tries to address that, so that we remove unnecessary debug code from hot operations.
First, making completion printing a config option keeps the size of
key method
SymDenotations#completeFromsmall. (completeFrom showed up as taking alomst 1% in the no HT profile)Second, we also make all tracing operations conditional on a Config option.
Third, we massage tracing operations themselves and tweak inlining so that no trace of the tracing operation remains in the generated code.