Skip to content

Turn off position checking for XML-generated blocks #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2017
Merged

Turn off position checking for XML-generated blocks #3235

merged 1 commit into from
Oct 4, 2017

Conversation

smarter
Copy link
Member

@smarter smarter commented Oct 3, 2017

@allanrenucci Can you check if this is good enough for scalatest?

@smarter smarter changed the title Avoid crash in Positioned#checkPos for xml literals Turn off position checking for XML-generated blocks Oct 3, 2017
@smarter
Copy link
Member Author

smarter commented Oct 3, 2017

I gave up fixing the positions and just turned off the position checker for XML blocks.

@smarter smarter requested a review from odersky October 3, 2017 16:10
@allanrenucci
Copy link
Contributor

This seems to do the trick

odersky
odersky approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we do what we have to do. Looking forward to the day where we can use xml interpolators instead.

@smarter smarter merged commit 60be656 into scala:master Oct 4, 2017
@allanrenucci allanrenucci deleted the fix-xml-pos branch December 14, 2017 19:21
@smarter smarter mentioned this pull request Dec 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smarter @allanrenucci @odersky