-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix ensureFreshScopeAfter always cloning scope #3222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test performance please |
performance test scheduled: 1 job(s) in queue, 0 running. |
Oops, I should have tested commit N-1 and N to get useful information. @liufengyun is there a way to cancel a running test? |
You can issue another test for |
Yes but they won't be in the correct order which will look confusing :). |
The hash will help disambiguate :) I manually cancelled the job, you can reissue the command. I'll add a command to cancel running jobs. |
Thanks! |
performance test failed: [check /data/workspace/bench/logs/pull-3222-10-01-16.08.out for more information] |
@liufengyun help 😄 ^ |
performance test scheduled for 196c23c ea1400frnrnheres some issue with the lock of jmh when force killing test: 1 job(s) in queue, 0 running. |
ouch, bad parsing :P |
performance test scheduled for 196c23c ea1400frn: 1 job(s) in queue, 0 running. |
There's some regression with the multi-commits test -- I just manually scheduled the test. |
The multi-commit command should work now with the fix (already deployed on server): liufengyun/bench@259f626 |
@liufengyun Are the tests still running? |
I just checked, there's now some issue with publishing website. I manually published below: http://dotty-bench.epfl.ch/3222-1/index.html But it only tests the first commit. |
test performance please |
performance test scheduled: 1 job(s) in queue, 1 running. |
Hmm this is going to be misleading because more stuff has been merged between the last test command 4 hours ago and the new test command now. |
After the current test finishes, it's possible to run |
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3222-1/ to see the changes. Benchmarks is based on merging with master (b7be521) |
`classInfo(prevCtx)` does not reload the denotation at `prevCtx`, so the if condition always returned true.
ea1400f
to
341bbd7
Compare
PR on top of #3216, only the last commit is new.