Skip to content

Fix #3130: Various fixes to inline #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 3, 2017
Merged

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Sep 28, 2017

No description provided.

Needs to be a TermType, or FirstTransform will replace it with a TypeTree.
Needs to be done after ExplicitOuter to make sure all needed
outer accessors have been installed.
 - Don't create an inline accessor wo a private field contained in the inlined method.
 - Don't create a this proxy to a class contained in the inlined method.
Otherwise base tyeps of inlined classes are wrong.
@odersky odersky changed the title Fix #3130: Fix inline wrt explicitOuter [WIP] Fix #3130: Fix inline wrt explicitOuter Sep 29, 2017
@odersky
Copy link
Contributor Author

odersky commented Sep 29, 2017

All the problems in the issue are now fixed, and some others as well.

@odersky odersky changed the title Fix #3130: Fix inline wrt explicitOuter Fix #3130: Various fixes to inline Sep 29, 2017
Copy link
Contributor

@OlivierBlanvillain OlivierBlanvillain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit d360ac0 into scala:master Oct 3, 2017
@allanrenucci allanrenucci deleted the fix-#3130 branch December 14, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants