Various fixes related to lambda adaptation #3203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix-lambda-nulls
branch
3 times, most recently
from
673eaed to
66098d3
Compare
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Needs rebase |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3203/ to see the changes. Benchmarks is based on merge(s) with master |
smarter
force-pushed
the
fix-lambda-nulls
branch
from
66098d3 to
9d296d8
Compare
@liufengyun I'm getting a 404 on this page |
|
It works on my phone, strange. Are you using Firefox or Chrome?
Le 28 sept. 2017 7:32 PM, "Guillaume Martres" <notifications@github.com> a
écrit :
… Visit http://dotty-bench.epfl.ch/3203/ to see the changes.
@liufengyun <https://github.com/liufengyun> I'm getting a 404 on this page
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3203 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAuDyeYkK7nA0AQKAA9SBfocm2mFZ0QXks5sm9g3gaJpZM4PnaXR>
.
|
|
Same issue with both firefox and chrome, however I don't get a 404 when I use curl or wget. |
|
Hah, it magically works now! |
nicolasstucki
approved these changes
Sep 30, 2017
|
Needs rebase |
When unboxing a null to a value class in Scala, the default value of the value class should be returned, before this commit an NPE was thrown instead. Like in scala/scala-java8-compat@d7e0125, we fix this by using BoxesRunTime, bun we don't use it for boxing since it's unnecessary. After this commit, we still throw NPE when unboxing nulls in unspecialized lambdas called in generic contexts (see if3_unspecialized in the added test). This is addressed by the next commits in this PR.
This commit does not change the end result of FunctionalInterfaces but makes the code easier to read, and add a `Definitions#isSpecializableFunction` method used in the next commit.
Previously, we only created bridges for derived value classes because we assumed the default adaptation done by LambdaMetaFactory was good enough. But this is not the case when unboxing null: LMF will throw an NPE when Scala semantics require using the default value of the value class instead. We fix this by creating more bridges when needed, this is similar to the solution adopted in scalac. Also fixed a bug where adapted closures did not preserve Closure#tpt, leading to a runtime failure in lambda-sam-bridge.scala
smarter
force-pushed
the
fix-lambda-nulls
branch
from
9d296d8 to
fe3c357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.