Skip to content

Homogenize mutable symbol maps #3122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2017
Merged

Homogenize mutable symbol maps #3122

merged 2 commits into from
Nov 22, 2017

Conversation

nicolasstucki
Copy link
Contributor

Use IdentityHashMap instead of mutable.HashMap to make fast equality check

@nicolasstucki
Copy link
Contributor Author

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/3122 to see the changes.

Benchmarks is based on merge(s) with master

@nicolasstucki
Copy link
Contributor Author

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/3122 to see the changes.

Benchmarks is based on merge(s) with master

@nicolasstucki
Copy link
Contributor Author

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/3122/ to see the changes.

Benchmarks is based on merge(s) with master

@nicolasstucki
Copy link
Contributor Author

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/3122/ to see the changes.

Benchmarks is based on merge(s) with master

@nicolasstucki nicolasstucki force-pushed the homogenize-symbol-maps branch from 3e54913 to 0b828e6 Compare October 11, 2017 07:14
@nicolasstucki
Homogenize mutable symbol maps
14d9fc2 
Use IdentityHashMap instead of mutable.HashMap to make fast equality check
@nicolasstucki
Use MutableSymbolMap update instead of put
9ce9ea3
@OlivierBlanvillain
Copy link
Contributor

LGTM!

@nicolasstucki
Copy link
Contributor Author

test performance please

@dottybot
Copy link
Member

performance test scheduled: 2 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/3122/ to see the changes.

Benchmarks is based on merging with master (cc43c34)

@nicolasstucki nicolasstucki merged commit 2acc7b3 into scala:master Nov 22, 2017
@allanrenucci allanrenucci deleted the homogenize-symbol-maps branch December 14, 2017 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierBlanvillain OlivierBlanvillain OlivierBlanvillain approved these changes

Assignees

@OlivierBlanvillain OlivierBlanvillain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @dottybot @OlivierBlanvillain