Skip to content

Fix #3108: avoid generating useless scripts in distribution #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2017
Merged

Fix #3108: avoid generating useless scripts in distribution #3109

merged 1 commit into from
Sep 13, 2017
+1 −0

Conversation

liufengyun
Copy link
Contributor

Fix #3108: avoid generating useless scripts in distribution

The updated version of sbt-pack by default generates scripts for all main methods, thus an explicit setting is required.

allanrenucci
allanrenucci approved these changes Sep 13, 2017
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun
Copy link
Contributor Author

Thanks @allanrenucci !

@liufengyun liufengyun merged commit 0bf5fe9 into scala:master Sep 13, 2017
@liufengyun liufengyun deleted the fix-3108 branch September 13, 2017 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrenucci allanrenucci allanrenucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liufengyun @allanrenucci