Remove duplication from UserFacingPrinter
#3032
Conversation
|
I probably won't have time to review this week, you may want to ask someone else.
The less stuff we have the better it is I think, if a separate printer is needed for the REPL it needs to be well justified. Also in e331f87 you put |
project/Build.scala
Outdated
| ) | ||
| }.evaluated, | ||
|
|
||
| repl := run.evaluated, |
There was a problem hiding this comment.
Missing a definition repl := in dotty-compiler now.
There was a problem hiding this comment.
Fixed in #3026 :)
felixmulder
force-pushed
the
topic/harmonize-printers
branch
2 times, most recently
from
fd124b7 to
3e4f2c7
Compare
As discussed with Guillaume Martres, this has the effect that if you depend on dotty-compiler version X, you also get the appropriate dotty repl with the same version
felixmulder
force-pushed
the
topic/harmonize-printers
branch
3 times, most recently
from
c922ea6 to
1d1a0e8
Compare
felixmulder
force-pushed
the
topic/harmonize-printers
branch
from
1d1a0e8 to
f7e9af9
Compare
|
It's great to have these things merged together, LGTM! |
| import NameOps._, StdNames._, Decorators._, Scopes.Scope, Types._, Texts._ | ||
| import SymDenotations.NoDenotation, Symbols.{ Symbol, ClassSymbol, defn } | ||
|
|
||
| class UserFacingPrinter(_ctx: Context) extends RefinedPrinter(_ctx) { |
There was a problem hiding this comment.
Do you use _ctx because ctx is already defined in RefinedPrinter?
There was a problem hiding this comment.
Yes and that's what we do in RefinedPrinter when extending plain printer :)
| @@ -18,7 +18,6 @@ val `dotty-bench-bootstrapped` = Build.`dotty-bench-bootstrapped` | |||
| val `scala-library` = Build.`scala-library` | |||
| val `scala-compiler` = Build.`scala-compiler` | |||
| val `scala-reflect` = Build.`scala-reflect` | |||
| val `dotty-repl` = Build.`dotty-repl` | |||
There was a problem hiding this comment.
Is it intentional to keep the dotty-repl project in Build.scala?
There was a problem hiding this comment.
Looks like an oversight when rebasing.
There was a problem hiding this comment.
(Remove it in #3044)
@smarter: how far do we want to take this? Should I try to get rid of
UserFacingPrintercompletely?I think there might be some things that won't print as expected if we do that. But I could try, anyway - up to you.