Fix #3018: use List instead of Map in InlineLocalObjects #3021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Map#values resulted in losing the original order or arguments, a List fixes that. The lookup cost will be slightly higher this way, but that should be negligible.
liufengyun
reviewed
Aug 25, 2017
| case Some(newSym) => ref(newSym) | ||
| } | ||
| newFieldsMapping.getOrElse(rec.symbol, Nil).collect { | ||
| case ((oldSym, newSym)) if oldSym == t.symbol => ref(newSym) |
There was a problem hiding this comment.
This is now linear. Consider using a LinkedHashMap instead.
| // | | New fields, replacements these getters | ||
| // | Usages of getters of these classes | ||
| // ValDefs of the classes that are being torn apart; = candidates.intersect(gettersCalled) | ||
| var newFieldsMapping: Map[Symbol, List[(Symbol, Symbol)]] = null |
There was a problem hiding this comment.
Aren't these fields supposed to be private?
There was a problem hiding this comment.
I didn't bother annotating everything private, but yes, everything is private[this] except inherited methods from transform.localopt.Optimisation which are private[transform.localopt].
|
LGTM |
smarter
reviewed
Aug 26, 2017
| @@ -0,0 +1 @@ | |||
| -optimise | |||
There was a problem hiding this comment.
flags files are ignored by vulpix, flags have to be put in the code in CompilationTests.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Map#values resulted in losing the original order or arguments, a List fixes that. The lookup cost will be slightly higher this way, but that should be negligible.