Skip to content

#1589 Move Parsers:2177 err to new format #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/parsing/Parsers.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2174,7 +2174,7 @@ object Parsers {
if (in.token == CLASS) tmplDef(start, addMod(mods, enumMod))
else enumDef(start, mods, enumMod)
case _ =>
syntaxErrorOrIncomplete("expected start of definition")
syntaxErrorOrIncomplete(ExpectedStartOfTopLevelDefinition())
EmptyTree
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public enum ErrorMessageID {
ImplicitFunctionTypeNeedsNonEmptyParameterListID,
WrongNumberOfParametersID,
DuplicatePrivateProtectedQualifierID,
ExpectedStartOfTopLevelDefinitionID,
;

public int errorNumber() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1702,4 +1702,12 @@ object messages {
hl"It is not allowed to combine `private` and `protected` modifiers even if they are qualified to different scopes"
}

case class ExpectedStartOfTopLevelDefinition()(implicit ctx: Context)
extends Message(ExpectedStartOfTopLevelDefinitionID) {
val kind = "Syntax"
val msg = "expected start of definition"
val explanation =
hl"you have to provide either ${"class"}, ${"trait"}, ${"object"}, or ${"enum"} definitions after qualifiers"
}

}
14 changes: 14 additions & 0 deletions compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -926,4 +926,18 @@ class ErrorMessagesTests extends ErrorMessagesTest {

assertEquals(DuplicatePrivateProtectedQualifier(), err)
}

@Test def expectedStartOfTopLevelDefinition =
checkMessagesAfter("frontend") {
"""private Test {}"""
}
.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
val defn = ictx.definitions

assertMessageCount(1, messages)
val err :: Nil = messages

assertEquals(ExpectedStartOfTopLevelDefinition(), err)
}
}