#1589 Move duplicate qualified modifier error to new format #2897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| val kind = "Syntax" | ||
| val msg = s"duplicate private/protected qualifier" | ||
| val explanation = | ||
| hl"""It is not allowed to combine `private` and `protected` modifiers even if they are qualified to different scopes""".stripMargin |
There was a problem hiding this comment.
You do not need .stripMargin here.
There was a problem hiding this comment.
You also do not need """ for the string, " is better.
| @@ -93,7 +93,8 @@ | |||
| ModifiersNotAllowedID, | |||
| WildcardOnTypeArgumentNotAllowedOnNewID, | |||
| ImplicitFunctionTypeNeedsNonEmptyParameterListID, | |||
| WrongNumberOfParametersID | |||
| WrongNumberOfParametersID, | |||
| DuplicatePrivateProtectedQualifierID | |||
There was a problem hiding this comment.
Add a , after DuplicatePrivateProtectedQualifierID
lorandszakacs
force-pushed
the
errmsg/lorandszakacs_parser_1703
branch
from
be34653 to
027b94f
Compare
|
@nicolasstucki, I addressed the issues. Thanks! |
|
@lorandszakacs thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a rather niched error message, since most of the time it is superseded by other errors.
This corresponds to the
Parsers:1703index from the issue description.P.S. I now realized that I will be leaving to areas with no internet soon... so hopefully all is well with the PR, otherwise I'll have to address it in a few days 😟