Skip to content

Upgrade collection strawman #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki requested a review from smarter July 16, 2017 19:56
@julienrf
Copy link
Contributor

What’s the goal of having this submodule?

@nicolasstucki
Copy link
Contributor Author

it is there to use it in the tests. Just to check that we are not breaking any of the language features used in the strawman. It a submodule to be able to make sure that it is always the same version of the code that gets tested for any given dotty commit.

@julienrf
Copy link
Contributor

OK. I think it’s a bit redundant because in scala/collection-strawman our CI also compiles the code with Dotty. But I think it makes more sense to check this in Dotty rather than in the collection-strawman repo.

@nicolasstucki
Copy link
Contributor Author

We want to know if a new commit in dotty would break the strawman (compilation) before merging it to master.
We additionally check the idempotency of the generated bytecode. I have another branch where I use it to build more complex separate compilation tests using those sources. Also currently working on some dotty benchmarks that should use a stable version of the strawman.

@smarter smarter merged commit 717bd99 into scala:master Jul 18, 2017
@allanrenucci allanrenucci deleted the upgrade-strawman branch December 14, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants