Fix #2871: Recognize more types as structural selections #2875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous condition was flawed because a type such as
{ val x: Int } && {}
should still be recognized as a structural selection of `x`.
|
@odersky sure. |
LPTK
approved these changes
Jul 17, 2017
| @@ -659,10 +659,8 @@ trait TypedTreeInfo extends TreeInfo[Type] { self: Trees.Instance[Type] => | |||
| rname == tree.name || hasRefinement(parent) | |||
| case tp: TypeProxy => | |||
| hasRefinement(tp.underlying) | |||
| case tp: OrType => | |||
| case tp: AndOrType => | |||
There was a problem hiding this comment.
Am I correct in assuming that if an intersection type has a component C that has a (non-structural) member f then a selection of .f on a value of that type will have its symbol filled in before isStructuralTermSelect is called?
Thus the condition !tree.symbol.exists below will not be satisfied, and we will not be issuing unnecessary structural selections. This is even if the type intersection also has a structural type containing a field f (on the other hand it seems like such types are consistently converted into refinements on C, e.g. C & {f:A} is represented as C{f:A} or just C if C#f =:= A).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous condition was flawed because a type such as
should still be recognized as a structural selection of
x. @LPTK, do you want to review?