Skip to content

Moved error message to case class scheme #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gvolpe
Copy link
Contributor

@gvolpe gvolpe commented Jun 11, 2017

Moved anonymous function missing parameter type error message to case class scheme.

Corresponds to Typer.scala:770 listed on the main issue: #1589

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Added" instead of "Add")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

Copy link
Contributor

@felixmulder felixmulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks, otherwise LGTM! 🎉

  • The commit message should be changed to something like: Move "Anonymous function missing param type" message to new error message scheme
  • The PR needs to be rebased to master, I do this by:
    $ git remote add upstream git@github.com:lampepfl/dotty
    $ git fetch upstream master && git rebase -i upstream/master
    $ git push -f

val explanation =
hl"""|Anonymous functions must define a type. For example, if you define a function like this one:
|
|val f = { case l@List(1,2,3) => Some(l) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For syntax highlighting this needs to be wrapped:

+           |${"val f = { case xs @ List(1, 2, 3) => Some(xs) }"}
-           |val f = { case l@List(1,2,3) => Some(l) }

Some spaces would also be awesome! 👍

|
|Make sure you give it a type of what you expect to match and help the type inference system:
|
|val f: Seq[Int] => Option[List[Int]] = { case l@List(1,2,3) => Some(l) } """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here with the wrapping :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixmulder , I'll try to fix it now in my lunch time :)

@gvolpe gvolpe force-pushed the anonymous-function-missing-type-parameter-error-to-case-class branch from b52e727 to c3fc832 Compare June 12, 2017 13:04
@gvolpe
Copy link
Contributor Author

gvolpe commented Jun 12, 2017

Hi @felixmulder , see if now it's fine whenever you can.
Cheers!

@gvolpe gvolpe changed the title [1589] Moved error message to case class scheme Moved error message to case class scheme #1589 Jun 12, 2017
@gvolpe gvolpe changed the title Moved error message to case class scheme #1589 Moved error message to case class scheme Jun 12, 2017
@felixmulder felixmulder merged commit cf44c8a into scala:master Jun 12, 2017
@felixmulder
Copy link
Contributor

Cool, thanks @gvolpe! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants