-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Moved error message to case class scheme #2731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved error message to case class scheme #2731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:
- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Added" instead of "Add")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nitpicks, otherwise LGTM! 🎉
- The commit message should be changed to something like:
Move "Anonymous function missing param type" message to new error message scheme
- The PR needs to be rebased to master, I do this by:
$ git remote add upstream git@github.com:lampepfl/dotty $ git fetch upstream master && git rebase -i upstream/master $ git push -f
val explanation = | ||
hl"""|Anonymous functions must define a type. For example, if you define a function like this one: | ||
| | ||
|val f = { case l@List(1,2,3) => Some(l) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For syntax highlighting this needs to be wrapped:
+ |${"val f = { case xs @ List(1, 2, 3) => Some(xs) }"}
- |val f = { case l@List(1,2,3) => Some(l) }
Some spaces would also be awesome! 👍
| | ||
|Make sure you give it a type of what you expect to match and help the type inference system: | ||
| | ||
|val f: Seq[Int] => Option[List[Int]] = { case l@List(1,2,3) => Some(l) } """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here with the wrapping :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @felixmulder , I'll try to fix it now in my lunch time :)
b52e727
to
c3fc832
Compare
Hi @felixmulder , see if now it's fine whenever you can. |
Cool, thanks @gvolpe! 🎉 |
Moved anonymous function missing parameter type error message to case class scheme.
Corresponds to Typer.scala:770 listed on the main issue: #1589