Moved literal message into error Message class #2725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hey @insdami! You need to configure git to use your github email (that's why your avatar is not on the commit) This is also so we can check that you've signed the Scala CLA. Thanks for the PR! |
|
Ops! Sorry about that @felixmulder, I'm using work's laptop. I guess the easiest thing to do it's create the PR again, right? |
…/github.com/insdami/dotty into expected-class-or-object-definition-message
|
@insdami - np, whichever! Here's how to do it using a rebase: https://stackoverflow.com/questions/3042437/change-commit-author-at-one-specific-commit |
|
Thanks for the PR @insdami! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.