Skip to content

Fix features.html links #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2017
Merged

Conversation

OlivierBlanvillain
Copy link
Contributor

No description provided.

@@ -72,7 +72,7 @@ <h1 id="talks-on-dotty">Talks on Dotty?</h1>
<li><a href="https://www.youtube.com/watch?v=GHzWqJKFCk4">Scala's Road Ahead</a> by Martin Odersky (<a href="http://www.slideshare.net/Odersky/scala-days-nyc-2016">slides</a>)</li>
<li><a href="https://www.youtube.com/watch?v=WxyyJyB_Ssc">Compilers are Databases</a> by Martin Odersky (<a href="http://www.slideshare.net/Odersky/compilers-are-databases">slides</a>)</li>
<li><a href="https://www.youtube.com/watch?v=aftdOFuVU1o">Exploring the future of Scala</a> by Dmitry Petrashko (<a href="https://d-d.me/scalaworld2015/#/">slides</a>)</li>
<p><a href="http://dotty.epfl.ch/docs/resources/talks.html#deep-dive-with-dotty">Deep Dive with Dotty</a></p>
<p><a href="http://dotty.epfl.ch/docs/resources/talks.html">Deep Dive with Dotty</a></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be pointing to the deep-dive-with-dotty section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jQuery disagrees, see what's live at http://dotty.epfl.ch/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Must be a bug in JQuery

I also just noticed the it should not be in a <p>, it should be in a <li>

Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to change the <p> to <li>

@nicolasstucki nicolasstucki merged commit 1f1b696 into scala:master Jun 1, 2017
@allanrenucci allanrenucci deleted the fix-features-links branch December 14, 2017 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants