add bootstrapped distribution #2588
Conversation
|
LGTM, but @smarter is the one who is most qualified to review this since he did the bootstrap. |
|
I've created a test bootstrapped release, you can try it as follows on Mac OS: brew remove dotty # if already installed, pity I didn't change the version
brew install dotty # use lampepfl/brew/dotty if it's the first time you install dottyThe zip and tar.gz can be downloaded for Linux/Windows as well. |
felixmulder
requested review from
smarter
and removed request for
felixmulder and
DarkDimius
project/Build.scala
Outdated
| settings(packSettings). | ||
| settings( | ||
| target := baseDirectory.value / "target", // override setting in commonBootstrappedSettings | ||
| triggeredMessage in ThisBuild := Watched.clearWhenTriggered, |
There was a problem hiding this comment.
Why is this here? If you want this, you can put it in your local sbt settings
There was a problem hiding this comment.
It's not really needed, it's copied from the setting for dotty, I'll remove it.
|
I'm going to say lgtm but I have no idea what this does, and I don't really want to know. |
|
Thanks @smarter , maybe you could also help check if the jars in the The particular question I have is about: whether we need |
Seems to be correct. At some point we need to stop using the bootclasspath for anything (it won't work with Java 9), but for now it's ok.
I assume you mean the |
|
Thanks a lot for the clarification @smarter , I merge this PR then. |
Now we can release bootstrapped packages by sbt:
dist/pack: create non-bootstrapped release underdist/target/packdist/pack-archive: create non-bootstrapped.zipand.tar.gzunderdist/targetdist-boostrapped/pack: create bootstrapped release underdist-bootstrapped/target/packdist-bootstrapped/pack-archive: create bootstrapped.zipand.tar.gzunderdist-bootstrapped/targetThe scripts are shared between the two.